Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/filestack-react #76

Open
vb2228 opened this issue Oct 28, 2019 · 11 comments · Fixed by #85
Open

@types/filestack-react #76

vb2228 opened this issue Oct 28, 2019 · 11 comments · Fixed by #85
Assignees

Comments

@vb2228
Copy link

vb2228 commented Oct 28, 2019

Hi,
I was trying to use filestack-react in typescript, but it didn't suppose @typescript.
Can anyone resolve this issue?

@pcholuj pcholuj self-assigned this Feb 12, 2020
@deltek-rossjackson
Copy link

Any update on this one?

@mpoisot
Copy link

mpoisot commented Aug 14, 2020

I see typescript has been added to Filestack-react, but for some reason types aren't working for me in VS Code. I'm able to use Filestack-react components just fine, it's only the typing that isn't working right.

I don't know much about how VS Code finds d.ts files, but perhaps it's because the d.ts file isn't located in the dist folder (it's only in the src folder)?

image

@BrentFarese
Copy link

BrentFarese commented Oct 17, 2020

So it seems that the distribution in the filestack-react package does not export types, which means that a TS project will not be able to resolve the types correctly, despite the types being present in src/index.d.ts. Can the project maintainers please expose the types in the distribution so that TS projects can consume those types?

It would be great if you can publish types to Definitely Typed or bundle the types correctly so they are exposed in the project. Thank you!

@deltek-rossjackson
Copy link

What we did in our codebase is that we recreated filestack-react and created our own button which is not hard to do. We use filestack-js which has the typings you need.

@mpoisot
Copy link

mpoisot commented Oct 19, 2020

What I ended up doing was create a file filestack-react.d at the top level of my project. I initially copied /src/index.d.ts, but I modified it a bit to eliminate warnings.

declare module "filestack-react" {
  import React from "react"
  import { PickerFileMetadata, ClientOptions } from "filestack-js"

  type FilestackAction =
    | "transform"
    | "retrieve"
    | "metadata"
    | "storeUrl"
    | "upload"
    | "multiupload"
    | "remove"
    | "pick"
    | "removeMetadata"
    | "preview"
    | "logout"

  type ComponentDisplayModeType = "button" | "link" | "immediate"

  interface Props {
    apikey: string | undefined
    action?: FilestackAction
    componentDisplayMode?: {
      type?: ComponentDisplayModeType
      customText?: string
      customClass?: string
    }
    onSuccess?: (data: PickerResponse) => void
    onError?: (error: PickerFileMetadata[]) => void
    clientOptions?: ClientOptions
    file?: File
    source?: string
    customRender?: React.ComponentType<{ onPick: (arg: unknown) => void }>
    actionOptions: OptionsObject
  }

  declare class ReactFilestack extends React.Component<Props> {}
  export default ReactFilestack
}

mpoisot added a commit to mpoisot/filestack-react that referenced this issue Oct 19, 2020
@BrentFarese
Copy link

BrentFarese commented Oct 19, 2020

These are valid workarounds but really the maintainer should publish types on DefinitelyTyped or generate and expose proper types in the dist directory. We are just consuming filestack-js as well but considered using the React component and ran across this common TS issue, which sort of prevented our use of the component.

@mpoisot
Copy link

mpoisot commented Oct 19, 2020

I figured out what was missing to get the existing types recognized and created a pull request.

@namoscato
Copy link

FYI v4.x also does not have any types.

@fishactual
Copy link

I realise everyone is busy but the fact that this package still does not have types is kind of a pain in the ass.

@zack-frontend
Copy link

This makes it incredibly difficult to use with React

@peterjhart
Copy link

Behold. https://www.npmjs.com/package/@types/filestack-react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants