Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve --restart, remove ensure with return #93

Merged
merged 1 commit into from Sep 4, 2018
Merged

Improve --restart, remove ensure with return #93

merged 1 commit into from Sep 4, 2018

Conversation

AlexWayfer
Copy link
Member

@AlexWayfer AlexWayfer self-assigned this Sep 2, 2018
@AlexWayfer
Copy link
Member Author

@luk3thomas, can you check, please, does it work for you?

  1. I don't like shadowing with local variables.
  2. I don't like unnecessary exceptions suppressing.
  3. Custom raise is unnecessary there.

So, I hope, I made code more transparent and easier. With the same result.

luk3thomas
luk3thomas approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@luk3thomas luk3thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like this should work 👏

@AlexWayfer AlexWayfer merged commit 6c4a7ce into master Sep 4, 2018
@AlexWayfer AlexWayfer deleted the improve_ensure_for_restart branch September 4, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luk3thomas luk3thomas luk3thomas approved these changes

Assignees

@AlexWayfer AlexWayfer

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWayfer @luk3thomas