Fix bug where order of transformer tests is incorrect #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/cloud/filibuster/junit/server/core/FilibusterCore.java
…into 193-order-of-transformer-tests # Conflicts: # CHANGELOG
cmeiklejohn
reviewed
Aug 17, 2023
src/main/java/cloud/filibuster/junit/server/core/TestExecutionQueue.java
Outdated
Show resolved
Hide resolved
|
Do you have a diagram or some sort of output to explain what the actual ordering change looks like? Hard to tell from this commit in isolation. |
|
This is the current incorrect order: 
|
|
This is the correct order with this PR: 
|
|
That looks good. What about two transformers? |
|
|
Can you just help me out with understanding why this is happening? It's probably OK that we don't fix, but I just want to understand why it's happening. |
# Conflicts: # CHANGELOG
|
If it's not completely fixed, open a new issue to track what's still not working and link here, and then I'll approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.