Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The @base attribute is only used if the remote contexts list is empty. #63

Closed
kevinpeterson opened this issue Aug 24, 2020 · 2 comments · Fixed by #76
Closed

The @base attribute is only used if the remote contexts list is empty. #63

kevinpeterson opened this issue Aug 24, 2020 · 2 comments · Fixed by #76
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kevinpeterson
Copy link
Contributor

Describe the bug

The @base attribute is only used if the remote contexts list is empty.

To Reproduce

Populate the @base attribute along with one or more entries in the remote contexts.

For example, I would expect this to result in one triple when going to RDF:

{
  "@id": "1",
  "test": "some-test",
  "@context": [
    "https://fhircat.org/fhir-r5/original/contexts/careplan.context.jsonld",
    {
      "nodeRole": {
        "@type": "@id",
        "@id": "fhir:nodeRole"
      },
      "@base": "http://hl7.org/fhir/",
      "owl:imports": {
        "@type": "@id"
      },
      "owl:versionIRI": {
        "@type": "@id"
      }
    }
  ]
}

Expected behavior

I believe the correct interpretation of this spec is that @base should be considered if the context is not a remote context (not necessarily if the remote contexts list is empty). See linked issue below.

Additional context

w3c/json-ld-api#505

@filip26 filip26 self-assigned this Aug 28, 2020
@filip26
Copy link
Owner

filip26 commented Aug 28, 2020

Hi,
thank you for reporting this.

<http://hl7.org/fhir/1> <http://example.com/UNKNOWN#test> "some-test" .

@kevinpeterson please, can you confirm is this the expected output?

@filip26 filip26 added this to the 0.8.5 milestone Aug 29, 2020
@filip26 filip26 added the duplicate This issue or pull request already exists label Aug 29, 2020
@filip26 filip26 added bug Something isn't working and removed duplicate This issue or pull request already exists labels Aug 29, 2020
@filip26
Copy link
Owner

filip26 commented Aug 29, 2020

Quite confusing, I'll go with removing @base from a remote context after 5.2.5.2 as suggested.

filip26 added a commit that referenced this issue Aug 30, 2020
@filip26 filip26 linked a pull request Aug 30, 2020 that will close this issue
filip26 added a commit that referenced this issue Aug 30, 2020
filip26 added a commit that referenced this issue Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants