Better workflow #34
Closed
Better workflow #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is ready Stream Trait is similar to the Future Trait in that it requires internal logic to let the executor know when the stream's state changes from Poll::Pending to Poll::Ready. In the original implementation mpsc channel and AtomicWakers were used. The AtomicWaker was used to contain the future's context and wake the task, while the channel was used to send AtomicWakers from Subscribers to the Publisher. After publishing a new item the Publisher collected all the AtomicWakers and called the wake method. This refactor replaces that logic with piper::Event which is awaited in the Stream::poll_next method until the Publisher signals that event by calling the Event::notify method. An additional close method was added to channel::Sender which explicitly let's all Receivers and Subscribers know that the Sender or Publisher has stopped publishing items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.