Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] General improvements #49

Merged
merged 9 commits into from
Oct 24, 2018
Merged

Conversation

filipealva
Copy link
Owner

Closes #8

  • Fix a bug that was selecting the wrong row as the middle one
  • Get deployment target back to iOS 8.0
  • Remove index parameter from delegate methods since it is meaningless for the developer implementing PickerView. It only exists because of the simulation of infinite rows, the end user (developer) should only care about the index represented in his datasource which is represented by the row parameter

@filipealva filipealva merged commit 51b3d55 into master Oct 24, 2018
@filipealva filipealva deleted the chore/general-improvements branch October 24, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant