fix: texto TabCoin no singular concatena com valor booleano #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smrsassa is attempting to deploy a commit to the TabNews Team on Vercel. A member of the Team first needs to authorize it. |
Rafatcb
added
front
| @@ -9,7 +9,7 @@ export default function TabCoinCount({ amount, direction, mode = 'tooltip', sx } | |||
| }, | |||
| full: { | |||
| iconSize: 20, | |||
| text: `${amount?.toLocaleString('pt-BR')} TabCoin${amount !== 1 && 's'}`, | |||
| text: `${amount?.toLocaleString('pt-BR')} TabCoin${Math.abs(amount) === 1 ? '' : 's'}`, | |||
There was a problem hiding this comment.
Considerem o que foi feito no #1461 como referência, então -1, 0 e 1 ficam no singular. Ficaria algo como:
Suggested change
| text: `${amount?.toLocaleString('pt-BR')} TabCoin${Math.abs(amount) === 1 ? '' : 's'}`, | |
| text: `${amount?.toLocaleString('pt-BR')} TabCoin${amount > 1 || amount < -1 ? 's' : ''}`, |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aprendendofelipe
requested changes
Jan 3, 2024
There was a problem hiding this comment.
@smrsassa, não passou no Lint do commit.
Use o comando npm run commit para criar a mensagem no padrão do projeto, ou use algo já no padrão, como:
fix(tabcoin_count): fix the singular TabCoin text
aprendendofelipe
approved these changes
Jan 3, 2024
|
@smrsassa, seu código já está rodando em produção! 🚀🚀🚀 Bem vindo à Turma de Contribuidores do TabNews! 👏👏👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mudanças realizadas
No componente TabCoinCount, existe uma condição para retirar ou adicionar o plural, dependendo se o usuário possui uma única ou mais TabCoins.
O problema ocorre quando o usuário possui apenas uma TabCoin. Nessa condição, a verificação
amount !== 1faz com que o seu retorno booleano seja concatenado na string "TabCoin", como por exemplo:Mudei essa condição utilizando o operador ternário para corrigir o problema.
Tipo de mudança