Corrige os testes de limite de tamanho do slug
#1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rafatcb
reviewed
May 22, 2024
tests/integration/api/v1/contents/[username]/[slug]/patch.test.js
Outdated
Show resolved
Hide resolved
aprendendofelipe
force-pushed
the
fix/slug-size-tests
branch
from
9ee85b7
to
a383876
Compare
Rafatcb
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mudanças realizadas
Corrige os dois testes que deveriam verificar se o
slugera corretamente truncado para o limite de 226 bytes, mas que não estavam verificando nada, já que o input já possuía exatamente o limite de 226 bytes. Agora os inputs dos testes possuem 227 bytes e podemos verificar que oslugé corretamente criado com os primeiros 226 bytes.A funcionalidade já estava correta, e inclusive estava sendo garantida por testes com títulos longos, mas esses dois testes específicos não garantiam nada.
Tipo de mudança