Usa o módulo crypto para gerar UUIDs e move o uuid para devDependencies
#1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafatcb
added
back
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kaique-soares
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Legal @Rafatcb 👍
Deixei sugestões em arquivos que faltou adicionar o prefixo node: caso ache que compense padronizar 👍
This module should be imported as `crypto` instead of `node:crypto` in files that will be executed in Vercel's Edge Middleware.
Rafatcb
force-pushed
the
refactor/uuid-dev-dependency
branch
from
3103c21
to
8e77fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mudanças realizadas
Esbarrei com o PR #1018 e decidi reimplementar. Não foi possível remover a biblioteca
uuid, porque usamos uma função dela para verificar a versão do UUID em testes, mas foi possível passar a bibliotecauuidpara ser uma dependência de desenvolvimento e utilizar o módulocryptopara gerar os UUIDs com.randomUUID().O módulo deve ser importado como
cryptoao invés denode:cryptonos arquivos que são executados em Middlewares Edge da Vercel, conforme documentação (aqui e aqui).Tipo de mudança
Checklist: