Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): clean body markdown - SEO #453

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

rodrigoKulb
Copy link
Contributor

🤔 Por que você está abrindo esse Pull Request?

🧐 Descreva sua solução:

Acabei encontrando o remove-markdown mais popular que as sugestões e não possui nenhuma dependência adicional, ele também remove as tags HTML, conforme exemplo abaixo:

Antes Depois
Captura de tela em 2022-06-11 13-41-19 Captura de tela em 2022-06-11 13-41-38

@vercel
Copy link

vercel bot commented Jun 11, 2022

@rodrigoKulb is attempting to deploy a commit to the TabNews Team on Vercel.

To accomplish this, @rodrigoKulb needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link
Owner

@filipedeschamps filipedeschamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muuuito massa @rodrigoKulb isso vai dar uma ajuda sensacional no SEO 😍 vários posts estavam ficando sujos no title. E acredito que com o merge desse PR nós finalizamos a parte de texto dessa Milestone sobre SEO.

Pedi um ajuste ali no package.json e aproveito para perguntar, você gerou o package-lock.json com a versão 16.15.0 do Node.js?

package.json Outdated
@@ -28,6 +28,7 @@
"react-dom": "18.1.0",
"react-icons": "4.3.1",
"recharts": "2.1.9",
"remove-markdown": "^0.5.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor, usar versão pinnada (sem o ^) nas dependências 👍

@filipedeschamps
Copy link
Owner

@rodrigoKulb vou fazer por aqui, fechado? 🤝

@rodrigoKulb
Copy link
Contributor Author

rodrigoKulb commented Jun 13, 2022

@filipedeschamps hoje estou na correria, com certeza manda brasa!

sobre o package-lock.json só foi atualizado o markdown mesmo pode verificar o diff

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tabnews ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 6:59PM (UTC)

@filipedeschamps
Copy link
Owner

Que massa, essa implementação mantém o alt de uma imagem 😍

@filipedeschamps filipedeschamps merged commit 1398954 into main Jun 13, 2022
@filipedeschamps
Copy link
Owner

Merged! Let's gooooo!!!!

@filipedeschamps filipedeschamps deleted the clean-body-markdown-seo branch June 13, 2022 19:07
@filipedeschamps
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants