Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli_pkg does not support version prefixed with v #80

Merged
merged 3 commits into from
Jun 18, 2021
Merged

cli_pkg does not support version prefixed with v #80

merged 3 commits into from
Jun 18, 2021

Conversation

ggrossetie
Copy link
Contributor

No description provided.

@ggrossetie
Copy link
Contributor Author

Seems to be working fine now: https://github.com/Mogztter/linkcheck/releases/tag/3.4.56
Everything is aligned, tag version, release version, changelog 👌🏻

@ggrossetie ggrossetie mentioned this pull request Jun 12, 2021
Merged
filiph
filiph approved these changes Jun 13, 2021
View reviewed changes
Copy link
Owner

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small suggestion.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@filiph @ggrossetie
Update .github/workflows/release.yml
ca43fde 
Co-authored-by: Guillaume Grossetie <ggrossetie@gmail.com>
@filiph filiph merged commit 4e60fe7 into filiph:master Jun 18, 2021
@ggrossetie ggrossetie deleted the fix-release-v-prefix branch June 19, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiph filiph filiph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggrossetie @filiph