Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper build pipeline #6

Closed
filipre opened this issue Mar 8, 2022 · 4 comments
Closed

Proper build pipeline #6

filipre opened this issue Mar 8, 2022 · 4 comments

Comments

@filipre
Copy link
Owner

filipre commented Mar 8, 2022

We should use Github Actions to test, build and deploy the package to pypi instead of doing it manually

https://github.com/pypa/gh-action-pypi-publish

  1. Build dist, think about where to set the version
  2. Deploy any PR to test pypi with version 0.{#PR} or some other incremental counter
  3. Deploy any release to pypi with given tag
@filipre
Copy link
Owner Author

filipre commented Mar 12, 2022

Requirements:

  • static versioning
  • pull requests should automatically deploy on test.pypi.org after approval
  • github releases should automatically deploy on pypi.org

Pull Request Opened

  1. Run Black, Flake8, tests
  2. Create a temp version to publish on test.pypi.org: Fork desired version: verison = version-pr.1, e.g. Pull Request 3: 1.0.41.0.4-pr.3
  3. Run poetry version $VERSION to temporarily change pyproject.toml
  4. Build package poetry build
  5. Publish package poetry publish
  6. Post link about deployed package in PR

Release/Publish

  1. It doesn't matter what tag we specify, it could be unique but it could also correlate with the one in pyproject.toml
  2. Run Black, Flake8, tests
  3. Build package poetry build
  4. Publish package poetry publish

@filipre
Copy link
Owner Author

filipre commented Mar 12, 2022

Todo: poetry support, black, flake8, http://mypy-lang.org/

@filipre
Copy link
Owner Author

filipre commented Mar 13, 2022

@filipre filipre closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant