-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New windows become disconnected from the original PWA #79
Comments
This passes a site config from the opener window to a new one and prevents some windows from becoming disconnected. However, this fix only applies to windows opened by shift-clicking on links, so windows opened using `target="_blank"` links or `window.open` will still become disconnected.
I'm having a similar problem, but probably distinct. I'm running Google Chat (chat.google.com) in Firefox PWA. When I click a link, say to a news website, I'd like to have it open in the system web browser (Firefox, default profile), but it loads in the PWA's window, replacing the PWA. If I use the context menu to open it in a new tab, similar results. Opening in a new window seems to use the same profile as the PWA, but at least doesn't replace the PWA. Is this the same or separate issue? |
If you want external links to open in a default browser, you can enable "Open out-of-scope URLs in a default browser" in the settings and add |
This is probably what I want, but I'm struggling to find these settings. I've looked under the PWAsForFirefox settings (1), the individual App settings (2), and the Profile settings (3). I even took a peek at the Add-On page for PWAsForFirefox, the general firefox settings page, and even about:config to see if I could find these and I can't seem to locate it. Do I need to be running an alpha/beta build of this extensions to see these settings? |
Ahh! Thank you! |
This issue has mostly been fixed by 5586d7e. |
Description
New windows become disconnected from the original PWA.
This only applies to windows opened by PWAs (for example, using
target="_blank"
links orwindow.open
), but not windows opened by a user with app/context menus, keyboard shortcuts or shift-clicking on links.On Windows, this means new windows will use the normal Firefox icon and probably merge with the normal Firefox shortcut in the taskbar. On Linux and macOS, this won't be so noticeable due to other issues. It will also cause them to lose functionality of changing window colors and will always have an address bar displayed.
Steps to Reproduce
target="_blank"
links.Possible Solution
This could be fixed if there is an easy way to intercept the opening of every new window, and pass it
window.gFFPWASiteConfig
from the original window just after it is created. I implemented this for some windows, but don't know how to do it for all windows.The text was updated successfully, but these errors were encountered: