Fix for issue nilsteampassnet#1539 verifying LDAP groups properly

The user was able to log in using LDAP even if he was not in the required group.
filo891 · Apr 27, 2017 · 3909749 · 3909749
1 parent 68ace1b
commit 3909749
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/sources/identify.php b/sources/identify.php
@@ -374,6 +374,9 @@ function identifyUser($sentData)
                        if (!ldap_count_entries($ldapconn, $result_group)) {
                                $ldapConnection = false;
                        }
+                       else {
+                               $ldapConnection = true;
+                       }
                     }
                     if ($debugLdap == 1) {
                         fputs(
@@ -382,7 +385,7 @@ function identifyUser($sentData)
                             'Results : ' . print_r(ldap_get_entries($ldapconn, $result), true) . "\n"
                         );
                     }
-                    if (ldap_count_entries($ldapconn, $result)) {
+                    if ($ldapConnection && ldap_count_entries($ldapconn, $result)) {
                         // try auth
                         $result = ldap_get_entries($ldapconn, $result);
                         $user_dn = $result[0]['dn'];