We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi there,
Great Work!
A couple of bugs you might want to fix:
you have an OBOE in your SimpleMixer.cs
@@ -74,7 +74,7 @@ namespace SimpleMixerSample int read = sampleSource.Read(_mixerBuffer, 0, count); for (int i = offset, n = 0; n < read; i++, n++) { (remove) if (numberOfStoredSamples < i) (add) if (numberOfStoredSamples <= i)
Also, I think you need this change:
@@ -152,7 +152,7 @@ namespace SimpleMixerSample { lock (_lockObj) { (remove) foreach (var sampleSource in _sampleSources) (add) foreach (var sampleSource in _sampleSources.ToArray()) { sampleSource.Dispose(); _sampleSources.Remove(sampleSource);
otherwise, it will throw exceptions (the mixer will try to remove sources that have already been removed).
Lastly, I think that FillWithZeros causes more problems than it solves. In particular, the stop event is not raised when FillWithZeros = true.
Schoene Gruesse :)
The text was updated successfully, but these errors were encountered:
58ec029
Fixed #24.
c934d3e
Fixed filoe#24.
b62461f
filoe
No branches or pull requests
Hi there,
Great Work!
A couple of bugs you might want to fix:
you have an OBOE in your SimpleMixer.cs
@@ -74,7 +74,7 @@ namespace SimpleMixerSample
int read = sampleSource.Read(_mixerBuffer, 0, count);
for (int i = offset, n = 0; n < read; i++, n++)
{
(remove) if (numberOfStoredSamples < i)
(add) if (numberOfStoredSamples <= i)
Also, I think you need this change:
@@ -152,7 +152,7 @@ namespace SimpleMixerSample
{
lock (_lockObj)
{
(remove) foreach (var sampleSource in _sampleSources)
(add) foreach (var sampleSource in _sampleSources.ToArray())
{
sampleSource.Dispose();
_sampleSources.Remove(sampleSource);
otherwise, it will throw exceptions (the mixer will try to remove sources that have already been removed).
Lastly, I think that FillWithZeros causes more problems than it solves. In particular, the stop event is not raised when FillWithZeros = true.
Schoene Gruesse :)
The text was updated successfully, but these errors were encountered: