[TASK] Extension creation

filoucrackeur · May 10, 2019 · 4f4bbca · 4f4bbca
1 parent 3db309a
commit 4f4bbca
Show file tree

Hide file tree

Showing 9 changed files with 59 additions and 63 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,25 +1,51 @@
 language: php
 
-php:
-  - 7.2
-  - 7.3
+matrix:
+  fast_finish: true
+  include:
+    - env: TYPO3_VERSION=^9.5 COVERAGE=1
+      php: 7.2
+    - env: TYPO3_VERSION=^9.5 COVERAGE=1
+      php: 7.3
 
-sudo: true
+
+sudo: false
+
+addons:
+  apt:
+    packages:
+      - parallel
 
 cache:
   directories:
     - $HOME/.composer/cache
 
+before_install:
+  - composer self-update
+  - composer --version
+
 before_script:
-  - Build/Scripts/runTests.sh -s composerInstall -p $TRAVIS_PHP_VERSION
+  - composer require typo3/minimal=$TYPO3_VERSION
+  - git checkout composer.json
+  - export TYPO3_PATH_WEB=$PWD/.Build/Web
+  - mkdir -p build/logs
 
 script:
   - >
-    echo "Running composer validate"
-    Build/Scripts/runTests.sh -s composerValidate -p $TRAVIS_PHP_VERSION
+    if [[ "$COVERAGE" == "0" ]]; then
+      echo;
+      echo "Running unit tests";
+      .Build/bin/phpunit --configuration phpunit.xml.dist --colors Tests/Unit/
+    fi
   - >
-    echo "Running unit tests";
-    Build/Scripts/runTests.sh -s unit -p $TRAVIS_PHP_VERSION
+    if [[ "$COVERAGE" == "1" ]]; then
+      echo;
+      echo "Running unit tests with coverage";
+      .Build/bin/phpunit --configuration phpunit.xml.dist --colors --coverage-text --coverage-clover build/logs/clover.xml Tests/Unit/
+    fi
+
+after_script:
   - >
-    echo "Running php lint";
-    Build/Scripts/runTests.sh -s lint -p $TRAVIS_PHP_VERSION
+    if [[ "$COVERAGE" == "1" ]]; then
+      travis_retry php .Build/bin/coveralls -v
+    fi
diff --git a/Classes/Controller/Backend/StorageFrameworkManagerController.php b/Classes/Controller/Backend/StorageFrameworkManagerController.php
@@ -81,6 +81,7 @@ public function session(ServerRequestInterface $request): ResponseInterface
      * @param ServerRequestInterface $request
      * @return ResponseInterface
      * @throws \TYPO3\CMS\Core\Cache\Exception\NoSuchCacheException
+     * @throws \TYPO3\CMS\Extbase\Mvc\Exception\InvalidExtensionNameException
      */
     public function core(ServerRequestInterface $request): ResponseInterface
     {
@@ -102,6 +103,7 @@ public function core(ServerRequestInterface $request): ResponseInterface
      * @param ServerRequestInterface $request
      * @return ResponseInterface
      * @throws \TYPO3\CMS\Core\Cache\Exception\NoSuchCacheException
+     * @throws \TYPO3\CMS\Extbase\Mvc\Exception\InvalidExtensionNameException
      */
     public function extensions(ServerRequestInterface $request): ResponseInterface
     {
@@ -118,37 +120,6 @@ public function extensions(ServerRequestInterface $request): ResponseInterface
         ]);
     }
 
-
-    /**
-     * @param ServerRequestInterface $request
-     * @return ResponseInterface
-     * @throws \TYPO3\CMS\Core\Cache\Exception\NoSuchCacheException
-     */
-    public function backend(ServerRequestInterface $request): ResponseInterface
-    {
-
-        $backend = GeneralUtility::makeInstance(CacheManagerService::class)
-            ->getSessionBackendByIdentifier('BE');
-//            ->getCacheBackendByIdentifier('cache_pages');
-
-        try {
-            $backend->getBackend()->validateConfiguration();
-        } catch (\Exception $e) {
-            var_dump($e);
-        }
-        die;
-
-        return new JsonResponse([
-            'success' => true,
-            'backend' => [
-                'identifier' => $backend->getIdentifier(),
-                'type' => $backend->getType(),
-                'status' => $backend->getStatus(),
-                'configuration' => $backend->getConfiguration(),
-            ],
-        ]);
-    }
-
     /**
      * @param CacheManagerService $cacheManagerService
      */

diff --git a/Classes/Type/Backend/Session.php b/Classes/Type/Backend/Session.php
@@ -14,7 +14,7 @@ class Session extends Enumeration
     /**
      * @return bool
      */
-    public function isFrontent(): bool
+    public function isFrontend(): bool
     {
         return $this->equals(self::FE);
     }

diff --git a/Classes/Utility/TreeUtility.php b/Classes/Utility/TreeUtility.php
@@ -11,6 +11,10 @@ class TreeUtility
      */
     public static function fromArray(array $array): string
     {
+        if (empty($array)) {
+            return '';
+        }
+
         $output = '<ul class="list-tree text-monospace">';
 
         foreach ($array as $key => $value) {

diff --git a/Classes/ViewHelpers/ConfigurationViewHelper.php b/Classes/ViewHelpers/ConfigurationViewHelper.php
@@ -3,7 +3,6 @@
 
 namespace Filoucrackeur\StorageFrameworkManager\ViewHelpers;
 
-use Exception;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 
 class ConfigurationViewHelper extends AbstractViewHelper
@@ -30,18 +29,13 @@ public function initializeArguments()
     }
 
     /**
-     * @return mixed
-     * @throws Exception
+     * @return array|null
      */
-    public function render()
+    public function render(): ?array
     {
-        if (!isset($this->arguments['type']) || null === $this->arguments['type']) {
-            throw new \RuntimeException('type must be string with value session or cache');
-        }
-
         if ($this->arguments['type'] === 'cache') {
 
-            if (isset($this->arguments['identifier']) && null !== $this->arguments['identifier']) {
+            if (isset($this->arguments['identifier']) && '' !== $this->arguments['identifier']) {
                 return $GLOBALS['TYPO3_CONF_VARS']['SYS']['caching']['cacheConfigurations'][$this->arguments['identifier']];
             }
 
@@ -50,7 +44,7 @@ public function render()
 
         if ($this->arguments['type'] === 'session') {
 
-            if (isset($this->arguments['identifier']) && null !== $this->arguments['identifier']) {
+            if (isset($this->arguments['identifier']) && '' !== $this->arguments['identifier']) {
                 return $GLOBALS['TYPO3_CONF_VARS']['SYS']['session'][$this->arguments['identifier']];
             }
 

diff --git a/Classes/ViewHelpers/TreeViewHelper.php b/Classes/ViewHelpers/TreeViewHelper.php
@@ -3,7 +3,6 @@
 
 namespace Filoucrackeur\StorageFrameworkManager\ViewHelpers;
 
-use Exception;
 use Filoucrackeur\StorageFrameworkManager\Utility\TreeUtility;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 
@@ -32,7 +31,6 @@ public function initializeArguments()
 
     /**
      * @return string
-     * @throws Exception
      */
     public function render(): string
     {

diff --git a/Configuration/Backend/AjaxRoutes.php b/Configuration/Backend/AjaxRoutes.php
@@ -20,8 +20,4 @@
         'path' => '/storage-framework-manager/show',
         'target' => Backend\StorageFrameworkManagerController::class . '::show'
     ],
-    'backend' => [
-        'path' => '/storage-framework-manager/backend',
-        'target' => Backend\StorageFrameworkManagerController::class . '::backend'
-    ],
 ];
diff --git a/Configuration/Backend/Routes.php b/Configuration/Backend/Routes.php
@@ -20,8 +20,4 @@
         'path' => '/storage-framework-manager/show',
         'target' => Backend\StorageFrameworkManagerController::class . '::show'
     ],
-    'backend' => [
-        'path' => '/storage-framework-manager/backend',
-        'target' => Backend\StorageFrameworkManagerController::class . '::backend'
-    ],
 ];
diff --git a/Tests/Unit/Controller/Backend/StorageFrameworkManagerControllerTest.php b/Tests/Unit/Controller/Backend/StorageFrameworkManagerControllerTest.php
@@ -0,0 +1,11 @@
+<?php
+declare(strict_types=1);
+
+namespace Filoucrackeur\StorageFrameworkManager\Tests\Controller\Backend;
+
+use Nimut\TestingFramework\TestCase\UnitTestCase;
+
+class StorageFrameworkManagerControllerTest extends UnitTestCase
+{
+
+}