Remove superfluous is_file() check #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gharlan could you confirm this fix? |
|
I just verified that this works as expected. therefore this is ready to land. |
|
Maybe we should also set the file contents cache to some special value, so we know to not keep going to the disk over and over if the file doesn't exist? |
Did you ever run into a situation in which it mattered? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this lines were added in the past to handle the case where $filePath is „Unknown“, see
f83625d
Later on a additional check for „Unknown“ was added for open_basedir related errors
1c0ffa0
Therefore the lines added in the first place are no longer usefull.
Additionally there is a feature request in #586 for which the mentioned lines are getting in our way.