Make sure we close all output-buffer we started beforehand

[staabm]

No description provided.

[staabm]

hmm not sure I understand what the builds errors try to tell me.

[Magentron]

This is as I have tested it.

[staabm]

since the build errors are still there, I dont think this is the right fix for the issue at least.

maybe it fixes your problem, but at least not the one reported by travis ;-)

[Magentron]

I'll try to have a better look at it later.

[staabm]

Hhmm I guess the source of the travis build warnings is here:

whoops/src/Whoops/Run.php

Lines 345 to 347 in 3ab01b9

	while ($this->system->getOutputBufferLevel() > 0) {
	$this->system->endOutputBuffering();
	}

[Magentron]

FWIW, work-around for a test:

• before doing something:

        $level = ob_get_level();

• at the end of the test:

        while (ob_get_level() > $level) {
            $content = ob_get_clean();
        }

[Magentron]

Who should I contact to get this PR merged?

[denis-sokolov]

Me! Thanks for the notice, I’ll take a look at it eventually.

[staabm]

These assignments could be moved before the try/catch

[Magentron]

You are so right, my bad, preparing to update PR

[denis-sokolov]

Thanks! 2.4.1.