Feature/3152 modules 2.0 rewrite #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filrak
requested changes
Jul 11, 2019
core/modules/catalog-next/index.ts
Outdated
| @@ -1,10 +1,7 @@ | |||
| import { categoryModule } from './store/category' | |||
| import { createModule } from '@vue-storefront/core/lib/module' | |||
| import { categoryNextStore } from './store/category' | |||
There was a problem hiding this comment.
to bedzie w przyszlosci zwykle category wiec named importy bym zostawil jak byly, tylko nazwa samego modulu VS niech bedzie next (jak byla)
core/modules/newsletter/index.ts
Outdated
| import { initCacheStorage } from '@vue-storefront/core/helpers/initCacheStorage' | ||
|
|
||
| export const KEY = 'newsletter' | ||
| const KEY = 'newsletter' |
There was a problem hiding this comment.
te key tez mozesz wywalic, to referowalo inicjalnie do klucza modulu, teraz takich juz nie ma (odnosi sie do wszystkich KEY)
added 5 commits
July 12, 2019 11:41
Issue-3152. Modules rewrite to match new design.
JCown
force-pushed
the
feature/3152-modules-2.0-rewrite
branch
from
2f89659
to
59a24da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
vuestorefront#3152
Short description and why it's useful
Rewrote modules to match new design (cart, catalog module rewrote by Filip as an example)
Upgrade Notes and Changelog
Contribution and currently important rules acceptance