Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Histogram, not Summary, in WAI #18

Merged
merged 5 commits into from Jul 2, 2017
Merged

Use Histogram, not Summary, in WAI #18

merged 5 commits into from Jul 2, 2017

Commits on Jul 2, 2017

  1. Put all the action-timing stuff in one place

    @jml
    jml committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    8d4a3f5 View commit details
    Browse the repository at this point in the history

  2. Use a monotonic clock

    @jml
    jml committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    ab5ea99 View commit details
    Browse the repository at this point in the history

  3. Use monotonic clock in WAI middleware

    @jml
    jml committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    e6a530a View commit details
    Browse the repository at this point in the history

  4. Measure seconds, not microseconds in WAI instrumentation 

    Brings us in line with Prometheus best practices:
https://prometheus.io/docs/practices/naming/#metric-names
    @jml
    jml committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    6e36765 View commit details
    Browse the repository at this point in the history

  5. Use histogram, not summary, in WAI 

    https://prometheus.io/docs/practices/histograms/ has a full discussion,
but the gist is that histograms can be aggregated across processes whereas
summaries cannot.

This makes histograms more useful in environments where there is more than one
process handling web requests, which is perhaps the more common case.
    @jml
    jml committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    f2be0f3 View commit details
    Browse the repository at this point in the history