Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on and configure test coverage reporting #32

Merged
merged 1 commit into from
Jan 31, 2015

Conversation

travisbrown
Copy link
Collaborator

No description provided.

@vkostyukov
Copy link
Collaborator

Are we going to add coveralls badge?

[![Coverage Status](https://coveralls.io/repos/finagle/finagle-serial/badge.svg)](https://coveralls.io/r/finagle/finagle-serial)

@travisbrown
Copy link
Collaborator Author

I wanted to be sure the integration tests were showing up in the Coveralls reporting numbers (they aren't). I'm planning to try to figure out why a little later this afternoon.

@vkostyukov
Copy link
Collaborator

Oh, ok. Looks good to me 👍

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 62b5cdb on travisbrown:set-up-scoverage into * on finagle:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c754bbf on travisbrown:set-up-scoverage into * on finagle:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f9ad9e2 on travisbrown:set-up-scoverage into * on finagle:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 05dc35c on travisbrown:set-up-scoverage into * on finagle:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 05dc35c on travisbrown:set-up-scoverage into * on finagle:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d70106e on travisbrown:set-up-scoverage into * on finagle:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c682218 on travisbrown:set-up-scoverage into * on finagle:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c682218 on travisbrown:set-up-scoverage into * on finagle:master*.

@travisbrown
Copy link
Collaborator Author

This is green after a lot of fussing, and the coverage number now includes integration tests. I've added a Coveralls badge.

Note that I've turned off Travis's container-based builds, since for the past couple of days (at least) it's been failing to download artifacts from Sonatype's snapshot repo, and in general it seems much flakier than the default.

travisbrown added a commit that referenced this pull request Jan 31, 2015
Turn on and configure test coverage reporting
@travisbrown travisbrown merged commit cef1708 into finagle:master Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants