Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings after migration to Scala 2.11.4 #109

Closed
vkostyukov opened this issue Dec 13, 2014 · 1 comment
Closed

Fix compiler warnings after migration to Scala 2.11.4 #109

vkostyukov opened this issue Dec 13, 2014 · 1 comment

Comments

@vkostyukov
Copy link
Collaborator

Most of the warning are in finch-json module:

[warn] /home/travis/build/finagle/finch/finch-json/src/main/scala/io/finch/json/Json.scala:63: match may not be exhaustive.
[warn] It would fail on the following input: Nil
[warn]     def loop(path: List[String], outer: Map[String, Any]): Option[A] = path match {
[warn]                                                                        ^
[warn] /home/travis/build/finagle/finch/finch-json/src/main/scala/io/finch/json/Json.scala:132: match may not be exhaustive.
[warn] It would fail on the following input: Nil
[warn]     def loop(path: List[String], value: Any): Map[String, Any] = path match {
[warn]                                                                  ^
[warn] /home/travis/build/finagle/finch/finch-json/src/main/scala/io/finch/json/Json.scala:161: object JSON in package json is deprecated: This object will be removed.
[warn]     JSON.parseFull(s) match {
@vkostyukov
Copy link
Collaborator Author

Fixed by #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant