Add Support for Scala 2.13 and drop support for Scala 2.11 #1204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
+ Coverage 80.29% 82.13% +1.84%
==========================================
Files 55 54 -1
Lines 1025 991 -34
Branches 40 42 +2
==========================================
- Hits 823 814 -9
+ Misses 202 177 -25
Continue to review full report at Codecov.
|
|
Hrm, not sure what's up with that coverage report. I might try to re-apply these changes directly to master instead of merging master into it. |
build.sbt
Outdated
| .aggregate( | ||
| core, fs2, iteratee, generic, argonaut, circe, benchmarks, test, jsonTest, examples, refined | ||
| core, fs2, iteratee, generic, argonaut, circe, benchmarks, test, jsonTest, /*examples,*/ refined |
There was a problem hiding this comment.
Doesn't examples work just fine with crossScalaVersions := Seq("2.12.7") setting?
There was a problem hiding this comment.
It works fine for sbt validate which doesn't cross build, but breaks on things like sbt +compile trying to fetch 2.13 dependencies. I think its because its inheriting the crossVersions of the aggregate project and not respecting the child projects override.
There was a problem hiding this comment.
Yeah, I see it now:
Issuing a cross building command, but not all sub projects have the same cross build configuration. This could result in subprojects cross building against Scala versions that they are not compatible with. Try issuing cross building command with tasks instead, since sbt will be able to ensure that cross building is only done using configured project and Scala version combinations that are configured.
I wish I'd understand whatever the Try issuing cross building command with tasks instead means
rpless
force-pushed
the
rpless/scala-2.13
branch
from
d5db5a3
to
64b1891
Compare
rpless
force-pushed
the
rpless/scala-2.13
branch
from
64b1891
to
c249f90
Compare
|
Ok I've managed to fix the coverage report by reapplying my changes to master instead of having the merge commit. I also cleaned up a couple unneeded things. AND because Travis released Circe 0.13 between when I posted this PR and when I got home, I was able to use that instead of the milestone build. |
sergeykolbasov
changed the title
|
I think I have all of the scalacOptions figured out. We were just missing the one in the 2.13 list. |
|
LGTM @vkostyukov what do you think? |
|
Hi @rpless twitter-server got released for 2.13 I guess we could finish this PR now and then merge it 😎 |
|
@sergeykolbasov I agree. I just pushed something to crossbuild examples and docs to 2.13. If it builds and you think its good I'll merge. |
build.sbt
Outdated
| @@ -1,44 +1,57 @@ | |||
| import ReleaseTransformations._ | |||
| import microsites.ExtraMdFileConfig | |||
|
|
|||
| parallelExecution := false | |||
There was a problem hiding this comment.
What's up with parallel execution? Also, does this line affect anything as it's not a part of any project?
There was a problem hiding this comment.
Oh, that's not needed, I'll take it out. I had in there cause one of the machines I develop on didn't quite have the horsepower to run all the tests at once and would lock up.
build.sbt
Outdated
| lazy val circeVersion = "0.11.2" | ||
| lazy val circeIterateeVersion = "0.12.0" | ||
| lazy val circeFs2Version = "0.11.0" | ||
| lazy val twitterVersion = "20.1.0" |
There was a problem hiding this comment.
I think it should be 20.3.0
|
@sergeykolbasov I've fixed the version of Twitter Server and removed that parallelExecution directive. Build looks good. |
|
LGTM 👍 |
Resolves #1202 by adding support for 2.13. We're also forced to drop support for 2.11 here because a number of dependencies that are not cross built for both. Big thanks to @sergeykolbasov for figuring the weird SAM issue that caused the Mapper to not get resolved in a bunch of cases.
Couple things about this PR: