Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imporve performance of body readers #474

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Conversation

vkostyukov
Copy link
Collaborator

There is still a room for improvements, but this is a good step forward: 30% less allocations and 20% better performance (running time) for string-based readers.

Before:

[info] BodyBenchmark.byteArray                           avgt   20   614.957 ±   9.786   ns/op
[info] BodyBenchmark.byteArray:·gc.alloc.rate.norm       avgt   20  3408.000 ±   0.001    B/op
[info] BodyBenchmark.byteArrayOption                     avgt   20   516.548 ±  83.328   ns/op
[info] BodyBenchmark.byteArrayOption:·gc.alloc.rate.norm avgt   20  3232.000 ±   0.001    B/op
[info] BodyBenchmark.string                              avgt   20  2933.702 ± 136.387   ns/op
[info] BodyBenchmark.string:·gc.alloc.rate.norm          avgt   20  9836.002 ±  10.691    B/op
[info] BodyBenchmark.stringOption                        avgt   20  2601.393 ±  52.171   ns/op
[info] BodyBenchmark.stringOption:·gc.alloc.rate.norm    avgt   20  9620.001 ±  10.691    B/op

After:

[info] BodyBenchmark.byteArray                           avgt   20   622.243 ±  18.590   ns/op
[info] BodyBenchmark.byteArray:·gc.alloc.rate.norm       avgt   20  3392.000 ±   0.001    B/op
[info] BodyBenchmark.byteArrayOption                     avgt   20   429.114 ±  10.309   ns/op
[info] BodyBenchmark.byteArrayOption:·gc.alloc.rate.norm avgt   20  3200.000 ±   0.001    B/op
[info] BodyBenchmark.string                              avgt   20  2498.887 ± 176.078   ns/op
[info] BodyBenchmark.string:·gc.alloc.rate.norm          avgt   20  7064.001 ±   0.003    B/op
[info] BodyBenchmark.stringOption                        avgt   20  2271.496 ± 120.459   ns/op
[info] BodyBenchmark.stringOption:·gc.alloc.rate.norm    avgt   20  6888.001 ±   0.003    B/op

@codecov-io
Copy link

Current coverage is 84.02%

Merging #474 into master will decrease coverage by -1.11% as of b4c5ec3

Powered by Codecov. Updated on successful CI builds.

vkostyukov added a commit that referenced this pull request Dec 2, 2015
Imporve performance of body readers
@vkostyukov vkostyukov merged commit 7baf41e into master Dec 2, 2015
@vkostyukov vkostyukov deleted the vkostyukov/bodies branch December 2, 2015 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants