Improve decoding errors from finch-circe #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkostyukov
reviewed
Sep 22, 2016
| @@ -4,6 +4,7 @@ import com.twitter.util.{Return, Throw, Try} | |||
| import io.circe.Decoder | |||
| import io.circe.jawn.decode | |||
| import io.finch.{Decode, Error} | |||
| import cats.syntax.show._ | |||
There was a problem hiding this comment.
I think these need to be sorted to make sbt scalastyle happy.
There was a problem hiding this comment.
Yes. I just came to exactly the same conclusion. I'll just fix that...
|
Oh no! I'm not stylish enough! |
Current coverage is 74.41% (diff: 100%)@@ master #648 diff @@
==========================================
Files 28 28
Lines 559 559
Methods 551 545 -6
Messages 0 0
Branches 8 14 +6
==========================================
Hits 416 416
Misses 143 143
Partials 0 0
|
|
Thanks @clhodapp! Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #647
Ping @vkostyukov