Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformly treat zero-length bodies as missing #796

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Conversation

vkostyukov
Copy link
Collaborator

Fixes #795.

@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #796 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #796     +/-   ##
=========================================
+ Coverage    79.7%   79.91%   +0.2%     
=========================================
  Files          44       44             
  Lines         680      682      +2     
  Branches       30       30             
=========================================
+ Hits          542      545      +3     
+ Misses        138      137      -1
Impacted Files Coverage Δ
core/src/main/scala/io/finch/endpoint/body.scala 61.76% <100%> (+5.51%) ⬆️
core/src/main/scala/io/finch/Endpoint.scala 73.07% <0%> (-0.77%) ⬇️
core/src/main/scala/io/finch/internal/Rs.scala 93.75% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64c966...b1b527f. Read the comment docs.

@vkostyukov vkostyukov merged commit 05f6c5f into master Jun 14, 2017
@vkostyukov vkostyukov deleted the vk/empty-bodies branch June 14, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants