Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster route parsing #943

Merged
merged 1 commit into from
May 31, 2018
Merged

Faster route parsing #943

merged 1 commit into from
May 31, 2018

Conversation

vkostyukov
Copy link
Collaborator

Addresses #942.

Benchmark results look promising:

BEFORE:

[info] Benchmark                                                   Mode  Cnt     Score     Error   Units
[info] InputBenchmark.fromEmptyPath                                avgt   10   165.508 ±  12.205   ns/op
[info] InputBenchmark.fromEmptyPath:·gc.alloc.rate.norm            avgt   10   280.000 ±   0.001    B/op
[info] InputBenchmark.fromPath                                     avgt   10   418.471 ±  10.846   ns/op
[info] InputBenchmark.fromPath:·gc.alloc.rate.norm                 avgt   10   664.000 ±   0.001    B/op

AFTER:

[info] Benchmark                                                   Mode  Cnt     Score     Error   Units
[info] InputBenchmark.fromEmptyPath                                avgt   10    14.236 ±   0.297   ns/op
[info] InputBenchmark.fromEmptyPath:·gc.alloc.rate.norm            avgt   10    24.000 ±   0.001    B/op
[info] InputBenchmark.fromPath                                     avgt   10   148.513 ±   6.581   ns/op
[info] InputBenchmark.fromPath:·gc.alloc.rate.norm                 avgt   10   384.000 ±   0.001    B/op

@codecov-io
Copy link

codecov-io commented May 30, 2018

Codecov Report

Merging #943 into master will increase coverage by 0.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
+ Coverage   81.33%   82.23%   +0.89%     
==========================================
  Files          50       50              
  Lines         793      805      +12     
  Branches       36       44       +8     
==========================================
+ Hits          645      662      +17     
+ Misses        148      143       -5
Impacted Files Coverage Δ
core/src/main/scala/io/finch/Input.scala 100% <100%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f99f5...9c677b6. Read the comment docs.

@vkostyukov vkostyukov merged commit b698648 into master May 31, 2018
@vkostyukov vkostyukov deleted the vk/fast-from-req branch May 31, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants