Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide FormValues for createDecorator #39

Merged
merged 1 commit into from Sep 2, 2020

Conversation

A11oW
Copy link
Contributor

@A11oW A11oW commented May 20, 2020

Fixes #38

If FormValues is specified for a form, then type 'Decorator<object>' is not assignable to type 'Decorator<FormValues>'
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           38        39    +1     
  Branches        14        14           
=========================================
+ Hits            38        39    +1     
Impacted Files Coverage Δ
src/decorator.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409c261...43d803b. Read the comment docs.

@afzalsayed96
Copy link

Came here for this. Hope it gets merged.

@marjorg
Copy link

marjorg commented Sep 2, 2020

Really need this in one of my projects as well. @erikras any chance of this getting approved and released?

@erikras erikras merged commit 20035fd into final-form:master Sep 2, 2020
@erikras
Copy link
Member

erikras commented Sep 2, 2020

Published in v1.3.2.

@afzalsayed96
Copy link

Hey @erikras, unfortunately it looks like the updated types are not published in v1.3.2.

https://unpkg.com/browse/final-form-calculate@1.3.2/dist/index.d.ts

@tokenvolt
Copy link

Confirm, the typings are missing in v1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide FormValues for createDecorator
5 participants