Adding support for dynamic update methods. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernerx
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 21 25 +4
Branches 3 4 +1
=====================================
+ Hits 21 25 +4
Continue to review full report at Codecov.
|
erikras
requested changes
Mar 6, 2018
src/decorator.js
Outdated
| const update = updates[destField] | ||
| form.change(destField, update(next, values)) | ||
| }) | ||
| if (updates instanceof Function) { |
|
Adjusted for using typeof. |
erikras
approved these changes
Mar 7, 2018
|
Can you update both |
|
I updated the readme. Unfortunately, I don't have enough experience with Flowtype to make the adjustment. Can you handle this? |
|
Hi Erik, I'm unsure - I don't want to put you under any pressure. It would be great, though, you could take over and release a new release. Thank you :) |
|
I can do it. Just gotta get around to it. 😄 |
|
Hi all ! how can i get this feature ? |
|
Published fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to use the "updates" field as a method for dynamically returning fields to update instead of just allowing a static list. It makes the whole package much for interesting when used in combination with final-form-arrays.
I also added a new test case to cover the new functionality.
Other tests and linting are looking good as well.
Fixed #5