Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Explicit Conversions? #161

Closed
sebpuetz opened this issue Aug 14, 2020 · 3 comments
Closed

Release Explicit Conversions? #161

sebpuetz opened this issue Aug 14, 2020 · 3 comments
Assignees

Comments

@sebpuetz
Copy link
Member

Not sure whether this should go as a dot-release or as a new version...

@danieldk
Copy link
Member

Do we have any API changes compared to the last dot release?

We probably need something in finalfusion-utils to use this API as well, right?

@sebpuetz
Copy link
Member Author

I just opened a (draft) PR in utils. Changes were a bump of OrderedFloat to 2.0 and addition of a new trait. Also a minor API-breaking change with the ExplicitIndexer now returning the mapping:

    pub fn new_with_indices(
        ngram_tuples: impl IntoIterator<Item = (String, u64)>,
    ) -> (Self, HashMap<u64, usize>)

used to be

    pub fn new_with_indices(
        ngram_tuples: impl IntoIterator<Item = (String, u64)>,
    ) -> (Self)

@danieldk
Copy link
Member

We expose ordered-float in the public API (we should probable change this), so we need a semver bump. I’ll do that on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants