Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and implement the ReadFastText trait #32

Merged
merged 1 commit into from Aug 2, 2019
Merged

Add and implement the ReadFastText trait #32

merged 1 commit into from Aug 2, 2019

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Aug 2, 2019

I guess that the build will fail, because new serde versions had incompatibilities with Rust 1.31. If so, I'll try to downgrade the dependency.

@danieldk danieldk added the feature New feature or request label Aug 2, 2019
@danieldk danieldk requested a review from sebpuetz August 2, 2019 13:14
@danieldk danieldk mentioned this pull request Aug 2, 2019
Closed
9 tasks
sebpuetz
sebpuetz approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@sebpuetz sebpuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the amount of conditional errors, the format seems much more convoluted.

I didn't find anything problematic, although I'm wondering whether the config should be pub.

src/fasttext/io.rs Outdated Show resolved Hide resolved
@danieldk danieldk merged commit 8f40782 into master Aug 2, 2019
@danieldk danieldk deleted the fasttext-io branch August 2, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebpuetz sebpuetz sebpuetz approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @sebpuetz