Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for vocab constructors. #81

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Docs for vocab constructors. #81

merged 1 commit into from
Oct 7, 2019

Conversation

sebpuetz
Copy link
Member

@sebpuetz sebpuetz commented Oct 7, 2019

Addresses #79

Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! However, there is other, unrelated stuff in the diff ;).

///
/// Words are assigned indices in the given order. NGrams in range `(min_n..max_n)` are
/// considered. The `indexer` is used to look up indices for the NGrams produced by this
/// SubwordVocab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add backticks around SubwordVocab.

@sebpuetz
Copy link
Member Author

sebpuetz commented Oct 7, 2019

Great! However, there is other, unrelated stuff in the diff ;).

Oops, git commit . does that. I'll amend the commit.

@danieldk danieldk merged commit aa0a515 into master Oct 7, 2019
@danieldk danieldk deleted the vocab-docs branch October 7, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants