Rename type and trait to comply with naming guidelines #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it controversial. It does break the existing API, but only in a shallow way, and it's better to fix this now than post-1.0. @sebpuetz what do you think? |
|
Yes, and I figured we already need an incompatible version bump for ndarray 0.15 compatibility anyway. |
|
No objections from my side. I think the ndarray bump to 0.15 is still blocked by ndarray-linalg |
|
Yeah, I just pinged them in rust-ndarray/ndarray-linalg#281. |
|
CI seems to be flaky; I noticed the same failure on #32. |
|
BTW, I was unable to compile the opq tests on my machine. I got the following error: = note: Undefined symbols for architecture x86_64:
"_sgesvd_", referenced from:
lapack::sgesvd::h128296f4358af73f in liblax-02fc496e925898f8.rlib(lax-02fc496e925898f8.lax.huv9ec90-cgu.1.rcgu.o)
"_ssyev_", referenced from:
lapack::ssyev::h8af130078dc2d88c in liblax-02fc496e925898f8.rlib(lax-02fc496e925898f8.lax.huv9ec90-cgu.1.rcgu.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation) |
What OS and against what library does the build link? E.g. You usually get this error when it is attempted to link against an OpenBLAS library without LAPACK support built in. |
|
macOS, installed openblas with |
Seems to link against the vendored OpenBLAS in openblas-src, then it's most likely that you do not have gfortran installed and as a result LAPACK is not built. |
|
Looks like the lint that used to warn for this is disabled now for public items: So, I propose that we keep the naming as-is. |
|
IMO there's still substantial value in complying with the API naming guidelines. If the next release will be semver-incompatible anyway because of the ndarray bump, I'd still change the names. |
|
I missed this, we could still do these changes for the next release. |
|
Rebased on master. |
danieldk
approved these changes
Nov 29, 2021
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose this is not so controversial? Thought I might help out by fixing this.