enable coverage test

.travis.yml

@@ -18,14 +18,28 @@ matrix:
 
   include:
     - rust: stable
+      sudo: required
+      addons:
+        apt:
+          packages:
+            - libcurl4-openssl-dev
+            - libelf-dev
+            - libdw-dev
+            - binutils-dev
       before_script:
         - rustup component add rustfmt-preview
+        - cargo install cargo-update || true
+        - cargo install cargo-kcov || true
+        - cargo install-update -a
         - export CARGO_INCREMENTAL=0
       script:
         - cargo update
         - cargo test --all-features
         - cargo fmt -- --check
         - if [[ "${TRAVIS_PULL_REQUEST_BRANCH:-}" = release-* ]]; then cargo package; fi
+      after_success:
+        - cargo kcov --print-install-kcov-sh | sh
+        - cargo kcov -v --coveralls
 
     - rust: beta
       before_script:

README.md

@@ -3,6 +3,7 @@
 [![crates.io](https://img.shields.io/crates/v/finchers-session.svg)](https://crates.io/crates/finchers-session)
 [![API documentation](https://img.shields.io/badge/api-docs-blue.svg)](https://finchers-rs.github.io/docs)
 [![Build Status](https://travis-ci.org/finchers-rs/finchers-session.svg?branch=master)](https://travis-ci.org/finchers-rs/finchers-session)
+[![Coverage Status](https://coveralls.io/repos/github/finchers-rs/finchers-session/badge.svg?branch=master)](https://coveralls.io/github/finchers-rs/finchers-session?branch=master)
 
 Session support for Finchers.
 

examples/simple.rs

@@ -9,7 +9,6 @@ extern crate pretty_env_logger;
 extern crate serde;
 extern crate serde_json;
 
-use finchers::error::Error;
 use finchers::prelude::*;
 
 use http::Response;
@@ -39,15 +38,20 @@ fn main() {
     let session = finchers_session::session(backend);
 
     let endpoint = path!(@get /).and(session).and_then(|session: Session| {
-        session.with(|session| -> Result<_, Error> {
+        session.with(|session| {
             // Retrieve the value of session.
             //
             // Note that the session value are stored as a UTF-8 string,
             // which means that the user it is necessary for the user to
             // deserialize/serialize the session data.
             let mut session_value: SessionValue = {
-                let s = session.get().unwrap_or("");
-                serde_json::from_str(s).map_err(finchers::error::bad_request)?
+                let s = session.get().unwrap_or(r#"{ "text": "" }"#);
+                serde_json::from_str(s).map_err(|err| {
+                    finchers::error::bad_request(format!(
+                        "failed to parse session value (input = {:?}): {}",
+                        s, err
+                    ))
+                })?
             };
 
             let response = Response::builder()

src/lib.rs

@@ -122,12 +122,10 @@ mod imp {
             f: impl FnOnce(&mut Self) -> R,
         ) -> impl Future<Item = R::Item, Error = Error>
         where
-            R: IntoFuture,
-            Error: From<R::Error>,
+            R: IntoFuture<Error = Error>,
         {
             f(&mut self)
                 .into_future()
-                .from_err()
                 .and_then(move |item| self.into_future().map(move |()| item))
         }
     }

tests/integration.rs

@@ -0,0 +1,22 @@
+extern crate finchers;
+extern crate finchers_session;
+
+use finchers::local;
+use finchers::prelude::*;
+use finchers_session::backend::cookie;
+
+type Session = finchers_session::Session<cookie::CookieSession>;
+
+#[test]
+fn test_no_op() {
+    let backend = cookie::plain();
+    let session = finchers_session::session(backend);
+
+    let endpoint = session.and_then(|session: Session| session.with(|_session| Ok("done")));
+
+    let response = local::get("/")
+        .header("host", "localhost:3000")
+        .respond(&endpoint);
+
+    assert!(!response.headers().contains_key("set-cookie"));
+}