Skip to content

Commit

Permalink
Fix case bug in cyberway golos address resolving
Browse files Browse the repository at this point in the history
Turns out you can't have uppercase letters in golos address or it will
be invalid with node returning error "Usernamer contains bad symbol".
So golos addresses are now lowercased.

Signed-off-by: alfred richardsn <rchrdsn@protonmail.ch>
  • Loading branch information
r4rdsn committed May 22, 2020
1 parent b827c35 commit 88bf675
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/escrow/blockchain/cyber_blockchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ async def _resolve_addresses(
) -> typing.Dict[str, str]:
# Change golos address to cyberway address
result = {}
data = [f"{address}@golos" for address in addresses]
data = [f"{address.lower()}@golos" for address in addresses]
while True:
cyberway_usernames = await self._api(
"v1/chain/resolve_names", data=data, raise_for_status=False
Expand All @@ -226,6 +226,8 @@ async def _resolve_addresses(
error_message = cyberway_usernames["error"]["details"][-1]["message"]
error_element = error_message.split()[-1]
data = [element for element in data if element != error_element]
if not data:
break
cyberway_username = error_element.split("@")[0]
result[cyberway_username] = cyberway_username
else:
Expand Down

0 comments on commit 88bf675

Please sign in to comment.