Skip to content

Commit

Permalink
Fix case bug in cyberway golos address resolving
Browse files Browse the repository at this point in the history
Turns out you can't have uppercase letters in golos address or it will
be invalid with node returning error "Usernamer contains bad symbol".
So golos addresses are now lowercased.

Signed-off-by: alfred richardsn <rchrdsn@protonmail.ch>
  • Loading branch information
r4rdsn committed May 22, 2020
1 parent b827c35 commit 98a4d46
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/escrow/blockchain/cyber_blockchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ async def _resolve_addresses(
data = [element for element in data if element != error_element]
cyberway_username = error_element.split("@")[0]
result[cyberway_username] = cyberway_username
if not data:
break
else:
for element, cyberway_username in zip(data, cyberway_usernames):
golos_address = element.split("@")[0]
Expand All @@ -242,10 +244,10 @@ async def _resolve_address(self, address) -> str:
async def _check_queue_in_history(
self, queue: typing.List[typing.Dict[str, typing.Any]],
) -> bool:
addresses = [queue_member["from_address"] for queue_member in queue]
addresses = [queue_member["from_address"].lower() for queue_member in queue]
resolved = await self._resolve_addresses(addresses)
for queue_member in queue:
queue_member["from_address"] = resolved[queue_member["from_address"]]
for queue_member, address in zip(queue, addresses):
queue_member["from_address"] = resolved[address]

pos = -1
min_time = self.get_min_time(queue)
Expand Down

0 comments on commit 98a4d46

Please sign in to comment.