Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF in loggers and taint analysis improvements #125

Merged
merged 10 commits into from Nov 6, 2015

Conversation

formanek
Copy link
Contributor

@formanek formanek commented Nov 6, 2015

New detectors (fixes #123, fixes #124), lower priority for HTTP response splitting (#121), extended method summaries configuration and main method arguments are considered tainted.

Note: I think there are enough improvements for a new release, I am planning support for taint sanitization for the next one

@h3xstream
Copy link
Member

Excellent! It's a great improvement to the method summaries for tainted and safe operations.
Marking main arguments is a good idea. Now I'm thinking about marking parameter using framework annotations such as spring @RequestParam or @PathVariable.

h3xstream added a commit that referenced this pull request Nov 6, 2015
CRLF in loggers and taint analysis improvements
@h3xstream h3xstream merged commit e2d709c into find-sec-bugs:master Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detector for external control of configuration (CWE-15) Detector for CRLF injection in logs (CWE-117)
2 participants