CWE 200 (Information Exposure) - Scala Play vulnerable code #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool idea. This include a huge block of method behavior (method summaries) for Scala string manipulation. This is a very good thing for all taint related analysis in Scala. (I am reviewing the changes) |
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
Please configure your IDE to avoid wildcards. (Minor issue)
For IntelliJ: http://stackoverflow.com/a/3348855/89769
|
Great contribution ! @MaxNad I have left 4 comments. If you can push the 4 small changes, I will merge the change. |
…a - Post code review modifications
|
I have pushed the modifications. Thanks for the comments. |
|
Perfect! Thanks again. I will wait for Travis-CI before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detector for information exposure in Scala Play.
If a controller returns a variable containing the result of a tainted call to the configuration manager, an attacker could use it to obtain sensitive data like the application key or the database credentials.
Taints can now be annotated with the "SENSITIVE_DATA" tag to allow a better scalability of the detector.
I also added multiple taint definitions for data structures in Scala, this will facilitate the development of injection based detectors in Scala Play.