Potential fix for issue #182 (INSECURE_COOKIE detector can be fooled by creating two or more cookies) #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ookie flag detection algorithm to handle multiple cookies in one method
…detection when multiple cookies are created
…xample use case found in bug find-sec-bugs#182
| ); | ||
| List<Integer> lines = Arrays.asList(new Integer[] { 68, 79, 88 }); | ||
| for (int line : lines) { | ||
| verify(reporter, never()).doReportBug( |
There was a problem hiding this comment.
Avoid using never() when the property line set. The broken tests could be badly fixed by adding new lines.
Most tests are using this pattern:
- Validate true positive first. (with the specific lines)
- Validate the count of true positive (
verify(reporter,times(X)).bugType("BUG_X").inClass("Class").inMethod("method").build())
There was a problem hiding this comment.
Noted.
I pushed a new version of the test file.
…ine numbers with the never() annotation
|
I will accept the change. On the long term, we will need to generalize the pattern trough a utility class or a base Detector. |
MaxNad
added a commit
to MaxNad/find-sec-bugs
that referenced
this pull request
Jul 27, 2016
…instance tracker detector
MaxNad
added a commit
to MaxNad/find-sec-bugs
that referenced
this pull request
Jul 27, 2016
…instance tracker detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the behavior of the CookieFlagsDetector and it now covers the example found in bug #182 .
It now behaves as a "mini taint detector", some of the default Find-Bugs checks are working like this (like the SqlInjection one) and they seem to work fine.
It first finds the cookie creation call, saves the position of the cookie on the stack and checks if it can find the .setHttpOnly or setSecure method for this object on the stack.