UNENCRYPTED_SERVER_SOCKET: use of java.net.ServerSocket #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything is good ! Good description, good detector, good tests. 👍 |
|
Great :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for detecting the use of plain java.net.ServerSocket instances, similar to the one already in place for java.net.Socket, and suggesting the use of SSL server sockets (through SSLServerSocketFactory).
The new UNENCRYPTED_SERVER_SOCKET vulnerability was relatively straightforward to integrate, it is similar to the one for UNENCRYPTED_SOCKET.
Please check if this is correct and can be integrated. The tests are passing, including the new one for UNENCRYPTED_SERVER_SOCKET. (I just did not update the Japanese translation metadata).
Best,
Eduardo Marques