Spring Unvalidated Redirect Detector #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The log of travis-ci was unavailable when I last checked. Now it is available : https://travis-ci.org/find-sec-bugs/find-sec-bugs/builds/216934937 The build failure is related to missing LGPL license header. |
h3xstream
reviewed
Apr 4, 2017
| public class SpringUnvalidatedRedirectController { | ||
|
|
||
| @RequestMapping("/redirect1") | ||
| public String redirect1(@RequestParam("url") String url) { |
There was a problem hiding this comment.
What if the return value is ModelAndView?
There was a problem hiding this comment.
It should detect redirects for String and ModelAndView return values. Essentially, the detector looks for string concatenation using the "redirect:" prefix in Spring controllers. This could lead to false positives, but there should be limited false negatives. I have updated the tests to confirm it will detect ModelAndViews and added LGPL license headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a detector for unvalidated redirects in Spring MVC web applications. The detector looks for a view prefix of "redirect:", which instructs the controller to perform a redirect to a specified URL. The detector only looks at classes with "RequestMapping" annotations. This should limit inspection to controllers and abstract classes that define endpoints.