Improve and generalize the CLI unix launcher #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's awesome. I am going to test the script for Linux. |
h3xstream
requested changes
Jan 25, 2019
cli/findsecbugs.sh
Outdated
|
|
||
| java -cp "$SOURCE/lib/\*:" edu.umd.cs.findbugs.LaunchAppropriateUI -quiet -pluginList lib/findsecbugs-plugin-1.8.0.jar -include include.xml $@ | ||
| java -cp $(echo $DIR/lib/*.jar | tr ' ' ':') edu.umd.cs.findbugs.LaunchAppropriateUI -quiet -pluginList $FINDBUGS_PLUGIN -include include.xml $@ |
There was a problem hiding this comment.
-include include.xml $@ should be -include $DIR/include.xml $@
If Spotbugs can't load the filter configuration, it will skip it silently.
If the tool is placed into the PATH, it will scan the target jar, but without the security rules. 😲
|
Sorry for the delay. I only found a small glitch. See the comment above. |
- Decouple the launcher from the find-sec-bugs version - Made it runnable from any directory - Fix a bug with certain JDK classloaders not able to load wildcards jars. - Handle superdirs with spaces
|
I included also another fix for handling superdirs with spaces in the names. |
h3xstream
approved these changes
Jan 26, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jars.
This work has been sponsored by Doyensec LLC