Taint sources locations added to bug reports #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3xstream
added a commit
that referenced
this pull request
Aug 2, 2015
Taint sources locations added to bug reports
|
Do IDE show those highlights (Eclipse/IntelliJ)? |
|
Only one line (with taint sink) is normally highlighted, but if the IDE plugin shows bug details (such as in IntelliJ), you can read the locations of taint sources (e.g. "At MyClass.java:[line 10]"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taint analysis remembers all possible code locations with taint sources from now and shows them in bug reports (e.g. lines are highlighted in FindBugs GUI). If taint source is unknown and sink known, locations of unknown sources are shown. This makes reported warnings more informative and false positives can be distinguished more easily.