A proposal for OpcodeStack.Item#defineNewSpecialKind() #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KengoTODA
added a commit
to KengoTODA/spotbugs
that referenced
this pull request
Nov 10, 2016
1. defineNewSpecialKind(String) method returns an int value which is not same with actual newly defined SpecialKind 2. specialKindNames field is not thread-safe, even though it is annotated with @StaticConstant so it will be shared between analysis runs. refs findbugsproject/findbugs#86 Squashed commit of the following: commit bb10ef2bd8ee4816f7b6bc0c4f4e855b9de5b144 Author: Kengo TODA <skypencil@gmail.com> Date: Fri Feb 19 05:29:35 2016 +0800 improve javadoc commit 3ead4633ec81aafbbe744f16d9bdaaf572b059ef Author: Kengo TODA <skypencil@gmail.com> Date: Fri Feb 19 05:20:21 2016 +0800 bugfix: StaticConstant should be threadsafe commit 5fae95bd38d56a0620edf094af3cca864b10023b Author: Kengo TODA <skypencil@gmail.com> Date: Fri Feb 19 05:16:28 2016 +0800 change behaviour of #defineNewSpecialKind(String) to make it intuitive commit 8e8de1fc958beca01205d93acb94e5d1a3ae7aa6 Author: Kengo TODA <skypencil@gmail.com> Date: Fri Feb 19 05:12:52 2016 +0800 reproduce strange behavior
|
I have no idea about this code and the mentioned change. |
|
Closing as merged in SpotBugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that current implementation has two problems:
defineNewSpecialKind(String)method returns anintvalue which is not same with actual newly defined SpecialKindspecialKindNamesfield is not thread-safe, even though it is annotated with@StaticConstantso it will be shared between analysis runs.Are they intended behaviour? Here I will propose JUnit tests to explain the first problem, and new implementation to solve both of two problems. Could you check it, please?
Note that this PR changes type of
specialKindNamespublic field. If we should keep it, we can usesynchronisedblock instead ofConcurrentMap.