This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Prevent message looping by getting id/username at runtime instead #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spype has a problem currently where the Skype username is used both to login and to block messages sent by the bot in skypeMessagesReceived. This doesn't work for (newer) users who cannot sign into Skype with a username, who must instead use an email, and it results in message looping.
Spype also currently requires you to set the Discord bot username in its config for the same purpose in discordMessageReceived, which is inconvenient.
I found that this can be avoided quite easily, by instead fetching the Skype username we are using from Skyweb, and similarly the userID of the bot from Discord IO.
This seems to work well for me, with an email based Skype user account and a token based Discord bot.
I've also included a second commit which removes the discord_username from the config.json file, since it has no use with this fix.
Best regards!