remove map access token

finderlein · Jun 9, 2023 · f32f921 · f32f921
1 parent d51fc81
commit f32f921
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 13 deletions.
diff --git a/.github/workflows/android_build.yml b/.github/workflows/android_build.yml
@@ -36,13 +36,11 @@ jobs:
       - name: Build App Bundle
         run: >-
           flutter build appbundle
-          --dart-define=THUNDERFOREST_API_KEY=${{ secrets.THUNDERFOREST_API_KEY }}
           --dart-define=IS_RELEASE=true
 
       - name: Build APK
         run: >-
           flutter build apk
-          --dart-define=THUNDERFOREST_API_KEY=${{ secrets.THUNDERFOREST_API_KEY }}
           --dart-define=IS_RELEASE=true
 
       - name: Upload AAB artifact
@@ -70,7 +68,6 @@ jobs:
       - name: Build F-Droid APK
         run: >-
           flutter build apk
-          --dart-define=THUNDERFOREST_API_KEY=${{ secrets.THUNDERFOREST_API_KEY }}
           --dart-define=IS_RELEASE=true
 
       # Required because F-Droid signs its apk with apksigner which produces a slightly different output than gradle signingConfig

diff --git a/README.md b/README.md
@@ -23,11 +23,6 @@ For help getting started with NÖ Finderlein development, view the
 [Flutter online documentation](https://flutter.dev/docs), which offers tutorials,
 samples, guidance on mobile development, and a full API reference.
 
-A File called `/lib/auth/secrets.dart` is needed with the following declared variables:
-
-```
-var mapAccessToken = "<mapbox api key>";
-```
 
 #### Android development
 

diff --git a/lib/auth/api.dart b/lib/auth/api.dart
@@ -1,6 +1,6 @@
-import './secrets.dart';
+// import './secrets.dart';
 
-var mapBoxAccessToken = mapAccessToken;
+// var mapBoxAccessToken = mapAccessToken;
 var mapUrl = "https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png";
 // "https://mapsneu.wien.gv.at/basemap/bmaphidpi/normal/google3857/{z}/{y}/{x}.jpeg";
 // "https://api.mapbox.com/styles/v1/derqurps/cl2c09wbh002i14pfmsce8b9t/tiles/256/{z}/{x}/{y}@2x?access_token=$mapAccessToken";

diff --git a/lib/src/utilities/secret_loader.dart b/lib/src/utilities/secret_loader.dart
@@ -15,14 +15,14 @@ class SecretLoader {
 }
 
 class Secret {
-  final String mapAccessToken;
+  // final String mapAccessToken;
   final String mapUrl;
   final String mapUrlDark;
 
-  Secret({this.mapAccessToken = "", this.mapUrl = "", this.mapUrlDark = ""});
+  Secret({this.mapUrl = "", this.mapUrlDark = ""});
   factory Secret.fromJson(Map<String, dynamic> jsonMap) {
     return Secret(
-        mapAccessToken: jsonMap["mapAccessToken"],
+        // mapAccessToken: jsonMap["mapAccessToken"],
         mapUrl: jsonMap["mapUrl"],
         mapUrlDark: jsonMap["mapUrlDark"]);
   }