This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Allow option for self signed certificates #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darArch can you have a look at the PR? Thank you |
|
This all looks good, could you do me a favour and merge master back in to see if my changes let the Travis build run successfully, currently I believe it's using misnamed environment variables in the |
|
@dararch not in until Monday. Will merge then... Cheers |
|
@darArch seems to be having the same behaviour as last week... |
|
@joaquin-corchero I'm going to merge your changes. The build is passing all tests and I suspect it is just failing the docker publish step due to being a branch/fork. Thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating tests against urls that have self signed certificates tests fail, the error being returned is
unable to get local issuer certificate.A new option rejectUnauthorized can be passed as part of the request object, setting it to false bypasses ssl validations:
"request":{ ... "rejectUnauthorized": false, ...}on both, hooks and main requests no error related to certificates should be returned.