Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install correct MS ODBC package #37

Closed

Conversation

pasibonfire
Copy link

Description

Install msodbcsql17 for Debian 9

Motivation and Context

Running the tests failed, ODBC 17 was not found.

Microsoft site states:

If you installed the v17 msodbcsql package that was briefly available, you should remove it before installing the msodbcsql17 package. This will avoid conflicts. The msodbcsql17 package can be installed side by side with the msodbcsql v13 package.

How Has This Been Tested?

Built a new image, ran docker-compose run mssql_ecto mix test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

If you installed the v17 msodbcsql package that was briefly available, you should remove it before installing the msodbcsql17 package.
https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server
@shdblowers
Copy link
Collaborator

Hello, @pasibonfire! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.174% when pulling f400721 on pasibonfire:fix_dockerfile_odbc into 5536623 on findmypast-oss:master.

@shdblowers
Copy link
Collaborator

@pasibonfire I think this is fixed now.

@shdblowers shdblowers closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants