SW-659 Add separate route for export debug information #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaifastafa
changed the title
zaifastafa
changed the title
TobiasGraml11
changed the title
Comment on lines
+177
to
+178
| $mainProduct = clone $result->first(); | ||
| $children = $mainProduct->getChildren(); |
There was a problem hiding this comment.
Not using a cloned instance of the product lead to the children being recursively added. So it was possible to do this:
$result->first()->getChildren()->last()->getChildren()->last()->getChildren()->last()->getChildren()->last()
Issue came up, because the JsonResponse class complained about recursion during JSON parsing:
Before:
- Requested Variant
- Sibling 1
- Sibling 2
- Main Variant
- Sibling 1 / Child 1
- Sibling 2 / Child 2
- Main variant
- .... (and so on)
Now:
- Requested Variant
- Sibling 1
- Sibling 2
- Main Variant
- Sibling 1 / Child 1
- Sibling 2 / Child 2
added 12 commits
March 28, 2022 16:26
…_debug_information' into SW-659_separate_route_for_export_debug_information
TheKeymaster
suggested changes
Apr 1, 2022
added 11 commits
April 14, 2022 15:18
|
Closing in favor of #285 |
TobiasGraml11
deleted the
SW-659_separate_route_for_export_debug_information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.