fix: don't set code 500 in status endpoint responses

fingerprintjs · Mar 29, 2024 · b4a4d04 · b4a4d04
1 parent bb8684f
commit b4a4d04
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/mgmt-lambda/handlers/statusHandler.ts b/mgmt-lambda/handlers/statusHandler.ts
@@ -25,10 +25,8 @@ export async function handleStatus(
     cloudFrontDistribution: cloudFrontDistributionInformation,
   }
 
-  const statusCode = lambdaFunctionInformation && cloudFrontDistributionInformation ? 200 : 500
-
   return {
-    statusCode: statusCode,
+    statusCode: 200,
     body: JSON.stringify(result),
     headers: {
       'content-type': 'application/json',

diff --git a/mgmt-lambda/test/app.test.ts b/mgmt-lambda/test/app.test.ts
@@ -366,7 +366,7 @@ describe('Basic test', () => {
     const event = generateStatusRequest(correctToken, 'GET', '///status')
 
     const result = await handler(event)
-    expect(result.statusCode).toBe(500)
+    expect(result.statusCode).toBe(200)
   })
 
   test('endpoint with trailing slashes', async () => {
@@ -377,7 +377,7 @@ describe('Basic test', () => {
     const event = generateStatusRequest(correctToken, 'GET', 'status/')
 
     const result = await handler(event)
-    expect(result.statusCode).toBe(500)
+    expect(result.statusCode).toBe(200)
   })
 
   test('endpoint with leading and trailing slashes', async () => {
@@ -388,7 +388,7 @@ describe('Basic test', () => {
     const event = generateStatusRequest(correctToken, 'GET', '//status/')
 
     const result = await handler(event)
-    expect(result.statusCode).toBe(500)
+    expect(result.statusCode).toBe(200)
   })
 
   test('status endpoint with additional path', async () => {

diff --git a/mgmt-lambda/test/handlers/handleStatus.test.ts b/mgmt-lambda/test/handlers/handleStatus.test.ts
@@ -174,6 +174,6 @@ describe('Handle mgmt-status', () => {
         .rejects()
 
       const status = await handleStatus(lambdaClient, cloudFrontClient, options)
-      expect(status.statusCode).toBe(500)
+      expect(status.statusCode).toBe(200)
     })
 })